Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the dapr scheme to be http so that the sidecar works #3292

Merged
merged 3 commits into from
Mar 30, 2024

Conversation

davidfowl
Copy link
Member

@davidfowl davidfowl commented Mar 30, 2024

This change broke the url because the scheme defaults to tcp (same as the protocol). This change also hides the dapr resources until we have a useful way to show them in the dashboard.

PS: This doesn't work yet, I have no idea why I can't call through the dapr side car.

#3290

Microsoft Reviewers: Open in CodeFlow

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Mar 30, 2024
@davidfowl davidfowl requested a review from karolz-ms March 30, 2024 01:54
@davidfowl davidfowl added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Mar 30, 2024
@davidfowl davidfowl added area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication dapr and removed NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Mar 30, 2024
@davidfowl davidfowl enabled auto-merge (squash) March 30, 2024 04:49
@davidfowl davidfowl merged commit 492482c into main Mar 30, 2024
8 checks passed
@davidfowl davidfowl deleted the davidfowl/fix-dapr-scheme branch March 30, 2024 05:03
@davidfowl
Copy link
Member Author

/backport to release/8.0-preview5

Copy link
Contributor

Started backporting to release/8.0-preview5: https://github.com/dotnet/aspire/actions/runs/8488775609

@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication dapr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants